Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not a bug, but some questions. #3

Open
Kevin-naticl opened this issue Jan 15, 2025 · 1 comment
Open

Not a bug, but some questions. #3

Kevin-naticl opened this issue Jan 15, 2025 · 1 comment

Comments

@Kevin-naticl
Copy link

Great work! About why it works i have some ideas, but IDK if i am right, So here i am.
My perspective:

Thought: Why is it that even though SVF has fewer trainable parts, it is still more effective?

From the perspective of linear transformation, among the three matrices derived from Singular Value Decomposition (SVD), the most crucial one is the middle matrix. The first and third matrices are essentially just rotations in the linear transformation. The diagonal matrix in the middle actually determines the scaling of weights across various dimensions. SVF can directly alter min(m,n) dimensions.

Secondly, during LoRA fine-tuning, it appears that there are (m+n)*r' parameters. However, if these two matrices are also subjected to SVD, in reality, when adjusting the most critical scaling dimensions, only r'+r' dimensions are actually available for use.

THX so much.

@floatingbigcat
Copy link
Collaborator

Hi @Kevin-naticl , Thank you for your interset and sharing your thought.

I think you are right. The information that the LoRA finetuning process can bring is essentially upper bounded by the number of RANK. Meanwhile, the SVF tunes the singular value matrix, it actually introduces full-rank information. Which we believe is where the effectiveness root from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants