Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Gem? #160

Open
vayu-technology opened this issue Jun 15, 2016 · 4 comments
Open

Update the Gem? #160

vayu-technology opened this issue Jun 15, 2016 · 4 comments

Comments

@vayu-technology
Copy link

redactor-rails gem 0.5.0 was released on February 24, 2015

Current codebase has commits from 2nd August 2015.

The reason I ask is because I just got caught out with the original image upload being returned instead of the content image. The github codebase had the changes but the gem did not. :/

@richpeck
Copy link

Why not pull from master branch in the Gemfile:

#Gemfile 
gem 'redactor-rails', github: "sammylin/redactor-rails"

@caJaeger
Copy link

caJaeger commented Jul 15, 2016

@richpeck Because at any given moment your production code could stop working with a bad commit in this project.

@NetScrn
Copy link

NetScrn commented Jul 20, 2016

And it does not work with turbolinks 5 :(

@denys-chaikovskyi
Copy link

@NetScrn to make it works with Turbolinks 5 you can just do the following in config.js (generated by rails generate redactor:config): replace the ready page:load with turbolinks:load, so it will look like this:

before:

$(document).on( 'ready page:load', window.init_redactor );

after:

$(document).on( 'turbolinks:load', window.init_redactor );`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants