Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParseEncryptedRawPrivateKey should return *ed25519.PrivateKey #6

Open
jduepmeier opened this issue Jan 22, 2020 · 0 comments
Open

ParseEncryptedRawPrivateKey should return *ed25519.PrivateKey #6

jduepmeier opened this issue Jan 22, 2020 · 0 comments

Comments

@jduepmeier
Copy link

To be compatible with the crypto/ssh the ParseEncryptedRawPrivateKey should return a pointer to ed25519.PrivateKey.
I think this can be fixed on this line:

sshkeys/parse.go

Line 210 in 82451a8

pk := ed25519.PrivateKey(make([]byte, ed25519.PrivateKeySize))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jduepmeier