Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Support Rails 5 #229

Open
ronen opened this issue Mar 5, 2016 · 9 comments
Open

Support Rails 5 #229

ronen opened this issue Mar 5, 2016 · 9 comments

Comments

@ronen
Copy link
Member

ronen commented Mar 5, 2016

Creating the issue...

...if anybody out there in github-land is interested in working on Rails 5 support for SchemaPlus, please let me know. I myself am a bit swamped these days so would welcome a collaborator stepping in.
(I haven't even looked into whether this would be hard or trivial.)

Thanks!

[This is a duplicate of SchemaPlus/schema_plus_core#9 which is where presumably most of the work would be]

@wangaguo
Copy link

I need schema_plus for rails 5 please.

@emptyflask
Copy link

Now that SchemaPlus/schema_plus_core#9 is merged, is the rest of this basically just updating dependencies, or is there a lot more work to be done in the other schema_plus gems?

@boazy
Copy link
Member

boazy commented Aug 18, 2016

Unfortunately, every gem I've went through so far had to be updated individually, but that doesn't mean all of them will.

@boazy
Copy link
Member

boazy commented Aug 21, 2016

Status update

The following gems are now released with full AR5 support and all tests passing:

  • schema_plus_compatibility (new)
  • schema_plus_core
  • schema_plus_indexes
  • schema_plus_foreign_keys
  • schema_plus_auto_foreign_keys
  • schema_plus_columns
  • schema_associations

The following gems are WIP:

  • schema_plus_pg_indexes (@myabc)
  • schema_plus_views (almost ready - just a few decisions need to be made)
  • schema_validations (still very early)

@jimcavoli
Copy link

I've opened up a PR with the changes for schema_plus_enums as well at SchemaPlus/schema_plus_enums#6 - it has one outstanding question over how the versioning should continue before merging.

@edwardmp
Copy link

@myabc
Can you share your progress on schema_plus_pg_indexes? I kind of need it it work with AR 5 so I might take a stab at it

@ACPK
Copy link

ACPK commented Aug 3, 2017

@edwardmp - Any update now that schema_plus_pg_indexes supports Rails5?

@edwardmp
Copy link

edwardmp commented Aug 3, 2017

@ACPK Ah great someone else did that. It seems that it's just schema_plus_views needs to be updated for AR 5.1 before the schema_plus gem itself can be updated.

@ronen
Copy link
Member Author

ronen commented Aug 10, 2017

Yes, the schema_plus gem itself can only be updated once all the individual gems have been updated.

But as per the README, "For the most part we recommend skipping [schema_plus] and directly including the specific feature gems you're interested in using."

So if the specific gems you need are already at 5.1 you can just require them directly and not bother waiting for schema_plus.

(...and if any gems you need are not yet ready for 5.1, any help to get them there would be greatly appreciated!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants