Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unkown events in the client #9410

Open
vxgmichel opened this issue Jan 22, 2025 · 2 comments · May be fixed by #9471
Open

Ignore unkown events in the client #9410

vxgmichel opened this issue Jan 22, 2025 · 2 comments · May be fixed by #9471
Assignees
Labels
A-Client Area: Parsec desktop application enhancement Improve functionality, potentially changing behavior
Milestone

Comments

@vxgmichel
Copy link
Contributor

In order to be able to add new events without breaking compatibility, we should ignore unrecognized events in the client.

At the moment, getting an unknown event would stop the monitor:

@vxgmichel vxgmichel added the A-Client Area: Parsec desktop application label Jan 22, 2025
@vxgmichel vxgmichel added this to the v3.3 milestone Jan 22, 2025
@mmmarcos
Copy link
Contributor

According to @touilleMan, because this is specific to events it should be done directly when the event is deserialized.

@touilleMan
Copy link
Member

The pragmatic approach would be to just ignore bad deserialization of response:

let cooked =
T::api_load_response(raw.as_ref()).map_err(|_| ConnectionError::BadContent)?;

This should be very easy to do, then we should add a sensible comment and a test... aaaaand we're done ! ^^

@mmmarcos mmmarcos added the enhancement Improve functionality, potentially changing behavior label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client Area: Parsec desktop application enhancement Improve functionality, potentially changing behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants