Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or update outdated invitation event #9411

Open
vxgmichel opened this issue Jan 22, 2025 · 0 comments
Open

Remove or update outdated invitation event #9411

vxgmichel opened this issue Jan 22, 2025 · 0 comments
Labels
A-Client Area: Parsec desktop application A-Server Area: Parsec Server
Milestone

Comments

@vxgmichel
Copy link
Contributor

vxgmichel commented Jan 22, 2025

This Invitation event is unused and outdated. It should be removed or updated in API v5:

"name": "Invitation",
"discriminant_value": "INVITATION",
"fields": [
{
"name": "token",
"type": "InvitationToken"
},
{
"name": "invitation_status",
"type": "InvitationStatus"
}
]
},

This also includes removing the claimers_ready attribute from the BaseInviteComponent which is also unused

self._claimers_ready: dict[OrganizationID, set[InvitationToken]] = defaultdict(set)

The invitation status structure might also need to be updated since the READY variant is not used anymore:

pub enum InvitationStatus {
Idle,
Ready,
Finished,
Cancelled,
}

@vxgmichel vxgmichel changed the title Remove outdated invitation event Remove or update outdated invitation event Jan 22, 2025
@vxgmichel vxgmichel added A-Client Area: Parsec desktop application A-Server Area: Parsec Server labels Jan 22, 2025
@vxgmichel vxgmichel added this to the v3.3 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client Area: Parsec desktop application A-Server Area: Parsec Server
Projects
None yet
Development

No branches or pull requests

1 participant