Skip to content
This repository has been archived by the owner on Jan 21, 2021. It is now read-only.

Animation issues (css-ripple-effect) #27

Closed
micahlt opened this issue Sep 28, 2020 · 3 comments
Closed

Animation issues (css-ripple-effect) #27

micahlt opened this issue Sep 28, 2020 · 3 comments
Labels
help wanted Extra attention is needed priority--2 Medium priority

Comments

@micahlt
Copy link
Member

micahlt commented Sep 28, 2020

We've got several issues with the css-ripple-effect npm package that oddly only occur on mobile (Android).

Here's how it appears in the browser (with cordova run browser):

ezgif-4-55451c5e35ab

And here's how it looks on mobile once compiled with cordova build android:

ezgif-4-631dc7b2a852

  • The ripple effect is instant and smooth in the browser, but there's a delay after the click on mobile.
  • The ripple effect is contained by the button element in the browser, but goes outside of the element on mobile.
  • You can vertically scroll the category bar on mobile (accidentally) but not in the browser and also in the browser.

All in all, this is not very pressing. However, it must be fixed before our public Play Store release.

@micahlt micahlt added help wanted Extra attention is needed priority--2 Medium priority labels Sep 28, 2020
@micahlt
Copy link
Member Author

micahlt commented Sep 28, 2020

Apparently the scrolling issue may be related to mladenplavsic/css-ripple-effect#10 in the library itself.

micahlt added a commit that referenced this issue Sep 28, 2020
@micahlt
Copy link
Member Author

micahlt commented Oct 5, 2020

The majority of this issue was fixed in 0be9bb2, so I'm closing it for now.

@micahlt micahlt closed this as completed Oct 5, 2020
@micahlt
Copy link
Member Author

micahlt commented Oct 19, 2020

Update: this is now fully irrelevant since we've replaced css-ripple-effect with a JavaScript alternative that is less glitchy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed priority--2 Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant