WAMimeType 'application/x-www-form-urlencoded' binary?

[adriaon]

Seaside considers the mime type 'application/x-www-form-urlencoded' to be binary. Shouldn't that be not binary?

[jbrichau]

I don't think it should be considered binary indeed. It's not very common to encounter it outside of http form submission requests, which are handled in a separate way, so that is probably why it has not really been an issue that WAMimeType>>isBinary does not correctly return false for it.

Could you maybe explain a bit more what context you encountered this as a problem? That might help in understanding a bit better to solve this.

[adriaon]

Sure. I encountered this issue when working on general logging of HTTP requests. By 'general' I mean without any specific application context. The MIME type is used to determine which class (either a string class or byte array) to use for the payload, and if any decoding is required based on the charset property of the MIME type.

[jbrichau]

I guess the fix for WAMimeType>>#isBinary will be:

	"answers whether the contents of a document of the receiving mime type are binary"
	self main = 'text' ifTrue: [ ^ false ].
	self main = 'application'
		ifTrue: [
			"application/json and application/x-www-form-urlencoded are text"
			(#('json' 'x-www-form-urlencoded') includes: self sub) ifTrue: [ ^ false ] ].
	GRPlatform subStringsIn: self sub splitBy: $+ do: [ :each |
		"application/(x-)javascript and application/xml are text"
		(#('x-javascript' 'javascript' 'xml') includes: each)
			ifTrue: [ ^ false ] ].
	^ true

Does that work for you?

[adriaon]

Looks good. Cheers.