Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dark/Light theme toggle #25

Open
ayushsgit opened this issue Oct 9, 2023 · 10 comments
Open

Improve Dark/Light theme toggle #25

ayushsgit opened this issue Oct 9, 2023 · 10 comments

Comments

@ayushsgit
Copy link

I would like to improve this button so that it looks more appealing

image

@KiranPranay
Copy link
Member

I would like to improve this button so that it looks more appealing

Yes, sure. If possible you can even try floating toggles.
Eg,
image

@KiranPranay KiranPranay changed the title Improvement in UI Improve Dark/Light theme toggle Oct 9, 2023
@ayushsgit
Copy link
Author

i see will try

@ayushsgit
Copy link
Author

hey i have changed the button but i am unable to deploy this site so i am unable to see the changes
is there a way to deploy it? so i can see real time changes?

@KiranPranay
Copy link
Member

hey i have changed the button but i am unable to deploy this site so i am unable to see the changes is there a way to deploy it? so i can see real time changes?

You can launch in your local machine just by double tapping at index.html or use http-server, vscode live server extension etc

@ayushsgit
Copy link
Author

https://github.com/ayushsgit/OpenCodeLaw-fork/tree/main/css
could you integrate on your end and check it

@KiranPranay
Copy link
Member

KiranPranay commented Oct 10, 2023

https://github.com/ayushsgit/OpenCodeLaw-fork/tree/main/css could you integrate on your end and check it

Here's your implementation.
Screencast from 2023-10-10 11-56-01.webm

You can even use, GitHub Codespaces to run virtually.
Also, plz pull the latest changes. Your index.html and opencodelaw.js have conflicts.

git fetch https://github.com/ServiceToMankind/OpenCodeLaw.git
git merge 568389834708dedc47b48329b8397d0c6b9c18aa 

@ayushsgit
Copy link
Author

ok working on it

@ayushsgit
Copy link
Author

Here are the updated changes : https://splendid-llama-755d96.netlify.app/
If you like them I would do a PR

@KiranPranay
Copy link
Member

KiranPranay commented Oct 11, 2023

Here are the updated changes : https://splendid-llama-755d96.netlify.app/ If you like them I would do a PR

To be precise, make

.nav .slider:before {
top : 53%;
}

Then, its good to go.

@ayushsgit
Copy link
Author

done
making a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants