Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor derp in dummy_dt function #27

Open
GeoZac opened this issue Nov 17, 2021 · 0 comments
Open

Minor derp in dummy_dt function #27

GeoZac opened this issue Nov 17, 2021 · 0 comments

Comments

@GeoZac
Copy link
Contributor

GeoZac commented Nov 17, 2021

When generating dummy dt, the PRODUCT_MANUFACTURER variable get sets with a minor derp

android_tools/tools/dummy_dt.sh

Line 275 in 483c4b4

printf "\nPRODUCT_MANUFACTURER := "$BRAND"" >> "$DT_DIR"/lineage_"$DEVICE".mk

For instance, in the case of Xiaomi devices, it gets written as
PRODUCT_MANUFACTURER := xiaomi [1]
instead of
PRODUCT_MANUFACTURER := Xiaomi [2]

  1. https://github.com/AndroidBlobs/device_xiaomi_surya/blob/46efa22aa8274a6d919961fa2843f831c71c0cce/lineage_surya.mk#L13
  2. https://github.com/LineageOS/android_device_xiaomi_surya/blob/4f03c8bd9cd3b51e67b815ea4eaafd8a032e811d/lineage_surya.mk#L31

on other OEMs, incorrect values gets written, eg. OnePlus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #27 capitalize the brand variable for the Xiaomi brand
1 participant
@GeoZac