Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Theme pull corrupts images and fonts #5224

Open
2 tasks done
ricardo-lewis opened this issue Jan 17, 2025 · 3 comments
Open
2 tasks done

[Bug]: Theme pull corrupts images and fonts #5224

ricardo-lewis opened this issue Jan 17, 2025 · 3 comments
Labels
Area: @shopify/theme @shopify/theme package issues Severity: 3 Normal Severity State: Waiting for feedback Type: Bug Something isn't working

Comments

@ricardo-lewis
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Perform a pull and all theme files should be downloaded intact.

Actual behavior

All text files are intact but all binaries such as images and fonts are corrupted.

Verbose output

Verbose output
Not doing verbose output as that would require me re-installing the bad version and I've already wasted many hours today solving this issue.

Reproduction steps

Install Shopify CLI (3.73.2)

Perform a theme pull in a fresh working copy.

Images and fonts will be corrupted.

Have confirmed this on two separate servers, both running different versions of Ubuntu.

Our current solution/workaround is to use version 3.61.2 of Shopify CLI.

Operating System

Ubuntu 24.04 and Ubuntu 22.04

Shopify CLI version (shopify --version)

3.73.2

Shell

zsh

Node version (run node -v if you're not sure)

18.20.3 and 18.20.5

What language and version are you using in your application?

No response

@ricardo-lewis ricardo-lewis added the Type: Bug Something isn't working label Jan 17, 2025
@gonzaloriestra gonzaloriestra added the Area: @shopify/theme @shopify/theme package issues label Jan 17, 2025
@karreiro
Copy link
Contributor

Thank you for reporting this issue, @ricardo-lewis!

Could you please perform a shopify theme pull --verbose --theme <theme_with_issues> even with your working version of the Shopify CLI?

With that, we can use request IDs to locate your store and theme, reproduce this problem, and fix it.

Thanks again for reporting this issue!

@ricardo-lewis
Copy link
Author

ricardo-lewis commented Jan 20, 2025

Theme ID is 131432939674

Here are some request IDs for images and font files that were correctly downloaded, since we still have v3.61.2 of Shopify CLI installed:

85d117f6-eacf-4b29-a73b-fc1558ad1a80-1737411015
70b893ee-29b4-4237-b399-2187c0267f0e-1737411015
48dc41b7-12ee-4a81-8d6c-6eac72ed44bf-1737411015
47fcc21e-1bbd-4677-a8af-71b4d7d219af-1737411016

Thank you for reporting this issue, @ricardo-lewis!

Could you please perform a shopify theme pull --verbose --theme <theme_with_issues> even with your working version of the Shopify CLI?

With that, we can use request IDs to locate your store and theme, reproduce this problem, and fix it.

Thanks again for reporting this issue!

@john3s
Copy link

john3s commented Jan 23, 2025

I have the same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Severity: 3 Normal Severity State: Waiting for feedback Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants