Remove deprecations about ActiveSupport::Deprecation #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt::Deprecation#behavior= It always stores an Array for the behavior.
Schwad
approved these changes
Nov 16, 2023
|
@etiennebarrie thanks for fixing this! Can we get a new release for this (and maybe other fixes)? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
A few random commits at first to clean things up. Then removed the deprecated calls in each test/spec file. Finally, to prevent a deprecation from the plugin being triggered on the project itself when running the tests, I defined the
Railsmodule intest/test_helper.rbin a way that's more similar to 7.1.We're still testing the other code path that's calling the deprecated API, but only when running tests with Active Support < 7.1.