Officially add null as Badge status option #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
vctrchu
approved these changes
Feb 4, 2025
Yes, I have the sandbox changes ready to go to support this, just need this version to go out so I can install it on the sandbox! https://github.com/Shopify/pos-e2e-ui-extension/pull/new/njo/badgescreen-status-null |
NathanJolly
force-pushed
the
njo/pos-add-banner-status-none
branch
from
440845a to
6298921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/Shopify/pos-next-react-native/issues/32885
Background
Badge has a prop called status that is optional. Typically, removing this prop should hide the icon, but something about the extensibility bridge retains the last-known value instead. This workaround allows partners to hide the icon, and is already in use per Shopify guidance.
Solution
This adds null as an officially supported badge status type so that folks know it's OK to use.
🎩
Set a Badge's status prop to something other than undefined or null.
Verify the status icon appears.
Set the Badge's status prop to null.
Verify the status icon disappears.
Checklist