Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModelLoader] MelangeURI is ignored when executing without animation #13

Open
fcoulon opened this issue Mar 27, 2017 · 5 comments
Open

Comments

@fcoulon
Copy link
Contributor

fcoulon commented Mar 27, 2017

When creating a RunConfiguration 'Gemoc Sequential eXecutable Model' without animation, the engine load a model without caring about the MelangeURI (like '?lang=MyLanguage' )

Seems caused by:

https://github.com/SiriusLab/ModelDebugging/blob/master/framework/execution_framework/plugins/org.gemoc.executionframework.engine/src/org/gemoc/executionframework/engine/commons/ModelExecutionContext.java#L73

https://github.com/SiriusLab/ModelDebugging/blob/master/framework/execution_framework/plugins/org.gemoc.executionframework.extensions.sirius/src/org/gemoc/executionframework/extensions/sirius/modelloader/DefaultModelLoader.java#L87-L98

We should write something like:

boolean useMelange = context.getRunConfiguration().getMelangeQuery() != null
				&& !context.getRunConfiguration().getMelangeQuery().isEmpty();
// calculating model URI as MelangeURI
URI modelURI = useMelange ? context.getRunConfiguration().getExecutedModelAsMelangeURI()
				: context.getRunConfiguration().getExecutedModelURI();
@ebousse
Copy link
Contributor

ebousse commented Mar 28, 2017

I just encountered the same problem, without even trying to reproduce the bug :).

Are you working on a fix?

@fcoulon
Copy link
Contributor Author

fcoulon commented Mar 28, 2017

No

@ebousse
Copy link
Contributor

ebousse commented Mar 28, 2017

OK I'm trying to reorganize the model loader to fix this.

@ebousse
Copy link
Contributor

ebousse commented Mar 28, 2017

Attempt to fix that in 4bab0c9, along with some refactoring, cleanups and comments. If you can test and if it works, you can close this.

@dvojtise
Copy link
Contributor

dvojtise commented Sep 5, 2017

with the transfer of the code to the Eclipse foundation (see gemoc@eclipse), this repository is now deprecated and replaced by https://github.com/eclipse/gemoc-studio-modeldebugging/

Please consider verifying/transfering this issue on a version based on the new official repository https://github.com/eclipse/gemoc-studio-modeldebugging/

Reminder : Eclipse CI for GEMOC : https://ci.eclipse.org/gemoc/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants