Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing demonstration data for example_birp.py #122

Open
setowenGit opened this issue Jan 7, 2025 · 7 comments
Open

Missing demonstration data for example_birp.py #122

setowenGit opened this issue Jan 7, 2025 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@setowenGit
Copy link

Hello, I’d like to express my appreciation for your work on the BiRP paper. It has been an insightful read, and I’m excited to dive deeper into the implementation.
I’ve been trying to follow along with the example_birp.py to better understand the concepts, but it seems to be missing the necessary demonstration data, which is causing the script to fail. Could you kindly provide the required data or let me know where I can find it?
Thank you so much for your time and assistance. I look forward to your response!

@Skylark0924
Copy link
Owner

Sorry for that. Since the data folder is quite large, I put the data on Google drive and forgot to mention it in README. Here is the link: https://drive.google.com/uc?id=1pOzD61CQJcy4L2hXveT1cGiD0AkIDt_c&export=download

@Skylark0924
Copy link
Owner

This link was mentioned in the install script

gdown https://drive.google.com/uc?id=1pOzD61CQJcy4L2hXveT1cGiD0AkIDt_c&export=download

@setowenGit
Copy link
Author

Thanks your reply and data!

@setowenGit setowenGit reopened this Jan 8, 2025
@setowenGit
Copy link
Author

Thank you for your reply! However, I’m sorry, I still couldn’t find the demonstration data used in example_birp.py. It seems that demo_exp_7.csv is used in the path /home/ubuntu/Data/optitrack_record/2023_03_29, but the data you provided doesn't seem to have the corresponding files.

@Skylark0924
Copy link
Owner

You can try https://github.com/Skylark0924/Rofunc/blob/main/examples/learning_ml/example_tpgmmbi_RPCtrl.py and https://github.com/Skylark0924/Rofunc/blob/main/examples/learning_ml/example_tpgmmbi_RPRepr.py first. Cause these are the examples shown in the paper to reveal the difference between method variants. The code you mentioned should be the one we used during real experiments, the exp data was not stored and I need some time to find out.

@setowenGit
Copy link
Author

Thank you very much for your response. However, I’m afraid I still have some additional questions. When I tried running the example_tpgmmbi_RPRepr.py script, I encountered an error:

bug1

I resolved the issue by modifying the code as follows:
demos_dx, demos_A, demos_b, demos_A_xdx, demos_b_xdx, demos_xdx, demos_xdx_f, demos_xdx_augm = repr.get_related_matrix()

This fix worked, but I encountered a new error:

bug2

I modified the code to:
follower_traj = reprs[follower]._reproduce(models[follower], follower_prod, ref_demo_idx, self.task_params[follower]['frame_origins'][0][0])

After this, the code ran successfully and I was able to generate the "Reproductions for new situations" figure.

However, when comparing the result with the figure in your BIRP paper, I noticed a significant difference: the meeting point of the two robot arms in my output is clearly not meeting, with a distance between them. I also tried increasing the number of iterations, but this did not help.

result

I would like to know if my modifications caused the problem or if the code itself still has some potential issues that led to this poor result. I hope that my feedback can help improve this excellent project.

Thank you again for your time and help!

@Skylark0924
Copy link
Owner

Let me check

@Skylark0924 Skylark0924 added the bug Something isn't working label Jan 16, 2025
@Skylark0924 Skylark0924 self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants