Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add timeouts to snowflake_dynamic_table #3355

Open
1 task
fabiomx opened this issue Jan 22, 2025 · 3 comments
Open
1 task

[Feature]: Add timeouts to snowflake_dynamic_table #3355

fabiomx opened this issue Jan 22, 2025 · 3 comments
Labels
feature-request Used to mark issues with provider's missing functionalities resource:dynamic_table Issue connected to the snowflake_dynamic_table resource

Comments

@fabiomx
Copy link

fabiomx commented Jan 22, 2025

Company Name

No response

Use Cases or Problem Statement

As mentioned in #3334, the snowflake_dynamic_table resource may require a longer timeout than Terraform's default during the creation phase, especially for large volumes of data.

To address this, it would be beneficial to add the timeouts configuration to this resource, similar to what was done for snowflake_execute.

Category

category:resource

Object type(s)

resource:dynamic_table

Proposal

No response

How much impact is this issue causing?

Low

Additional Information

No response

Would you like to implement a fix?

  • Yeah, I'll take it 😎
@fabiomx fabiomx added the feature-request Used to mark issues with provider's missing functionalities label Jan 22, 2025
@sfc-gh-asawicki
Copy link
Collaborator

Hey @fabiomx. Thanks for creating the issue.

We want to discuss the timeout topic in general and implement it in all suitable places (or even all the resources). We won't probably be able to address it before the GA, so I will keep this issue open for the time being.

One question, though: did you encounter the problem in your current setup, or is it a potential problem? In the latter case we may consider adding the timeout only to this resource but we also encourage contribution following our guidelines and the PR implementing the same functionality for the snowflake_execute resource #3337 .

@fabiomx
Copy link
Author

fabiomx commented Jan 29, 2025

Hey @sfc-gh-asawicki, thanks for getting back to me.

Yes, I'm experiencing the issue in my current setup. For example, yesterday, I had to create some dynamic tables one by one via -target option to make it work. Although I had increased the warehouse size, the warehouse's resources were still insufficient to handle all the dynamic table creations within 20 minutes. I believe that the initial loading might be significant in some cases.

As for contributing, I can't really focus on it right now, but I might consider it over the coming weeks, following your PR as a reference. Thanks!

If you have any other questions, feel free to reach out.

@sfc-gh-asawicki
Copy link
Collaborator

Hey @fabiomx. I will keep that in mind and we may be able to add these timeouts sooner.

@sfc-gh-asawicki sfc-gh-asawicki added the resource:dynamic_table Issue connected to the snowflake_dynamic_table resource label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Used to mark issues with provider's missing functionalities resource:dynamic_table Issue connected to the snowflake_dynamic_table resource
Projects
None yet
Development

No branches or pull requests

2 participants