Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge linedTable and generalTable CSS styles #1054

Open
PaulMorris opened this issue Aug 24, 2018 · 0 comments
Open

Merge linedTable and generalTable CSS styles #1054

PaulMorris opened this issue Aug 24, 2018 · 0 comments

Comments

@PaulMorris
Copy link
Contributor

In PR #1049 we introduced a linedTable CSS class to draw lines between table rows of certain tables and increase the line-height in table cells a bit. This let us only affect those tables we were working on in that PR.

But eventually it probably makes sense to merge the linedTable styles into the generalTable class styles, so all tables have those styles for consistency and to simplify things. We didn't do this at the time because we'd want to check how those new styles would affect the many generalTable instances, and there wasn't bandwidth to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants