Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #46

Open
6 tasks
parv3213 opened this issue Nov 29, 2023 · 0 comments
Open
6 tasks

Improvements #46

parv3213 opened this issue Nov 29, 2023 · 0 comments

Comments

@parv3213
Copy link
Member

parv3213 commented Nov 29, 2023 •
edited
Loading

  • Add contract versioning
  • Maximum coverage
  • Ensure that we are checking for math in our tests
  • I think we can remove redeem(address _collateral, uint256 _usdsAmt, uint256 _minCollAmt, uint256 _deadline) , and at its place use redeem(address _collateral, uint256 _usdsAmt, uint256 _minCollAmt, uint256 _deadline, address _strategy) and if user wants to use the default strategy the UI can send address(0) .
  • Remove _validateRwdClaim
  • Make distributeAndBurnSPA internal

Points mentioned here may also apply to the Demeter contracts.
@parv3213 parv3213 changed the title Required Improvements Improvements Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parv3213