Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow read-access to nested user collections for disabled users #213

Open
1 task done
pauljohanneskraft opened this issue Jan 24, 2025 · 0 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@pauljohanneskraft
Copy link
Collaborator

Problem

Currently, a user has read access to some of its nested collections, even if they have a disabled account. This is the case due to a previous bug of the client applications where it wasn't ensured that a token refresh happens before snapshot listeners are installed during enrollment. With this issue out of the way, we can restrict the rules again.

Solution

Make sure a user is not only authenticated with the respective userId in the Firestore rules, but also check that the user is fully enrolled and enabled.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@pauljohanneskraft pauljohanneskraft added the enhancement New feature or request label Jan 24, 2025
@pauljohanneskraft pauljohanneskraft self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant