Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pipelines - Prod #1499

Closed
8 of 12 tasks
wg102 opened this issue Jan 11, 2023 · 7 comments
Closed
8 of 12 tasks

Remove Pipelines - Prod #1499

wg102 opened this issue Jan 11, 2023 · 7 comments
Assignees

Comments

@wg102
Copy link
Contributor

wg102 commented Jan 11, 2023

This is based on the issue we created for dev here: #1449

Note:

  • Do we need to give a warning to the users before?
  • Might need to ask permissions from people
  • Might want to split this in multiple issues

It might include multiple steps.

  • Double check resources to make sure no pipelines are currently in use

Repo: aaw-kubeflow-manifests : StatCan/aaw-kubeflow-manifests#291

  • Remove the pipelines from the menu
    • kustomize/apps/centraldashboard/base/centraldashboard-config.yaml
  • Remove the deployment form the aaw-kubeflow-manifest
    • Remove the pipeline folders pipeline/base

Repo: aaw-argocd-manifests https://github.com/StatCan/aaw-argocd-manifests/pull/240

Repo: aaw-kubeflow-profiles-controller and Charts

And if a newer version exists, so the chart won't be bumped to the version on file, but a newer one.

After the code is in prod

  • Checkout if there are any resources left after (config maps, secrets, deployments, etc.)
  • Create a deprecation script to clean up the resources
  • Once in prod, test using Pipeline Removal Testing - Prod #1514

Possibly another task entirely:

  • Create a script to remove the pipeline labels from the pods/notebooks - note: might need restart?
@wg102
Copy link
Contributor Author

wg102 commented Jan 11, 2023

Note: #1498 needs to be completed first

@wg102
Copy link
Contributor Author

wg102 commented Jan 16, 2023

Q: Do we need to give a warning to the users before?
A: No need if it doesn't disturb prod and create down time, which it should not. Kubeflow will not, and the controller modifications should not either. As far as removing the labels (sometime in the future) goes, it is undetermined as of now.

Q: Might need to ask permissions from people
A: Since it will not disturb their normal day, and as far as we know, from experience, from the current pipeline (or lack of) and from the survey, no one is using pipelines, therefore we can delete it.

Q: Might want to split this in multiple issues
A: As needed be.

Q: Why are we deprecating pipelines?
A: Mostly because of the maintenance burden, and i18n issues. On top of the fact that no user actively uses the component. it because too much effort for the low reward. Users will eventually be able to use another way such as (possibly) argo workflow instead.

@wg102
Copy link
Contributor Author

wg102 commented Jan 17, 2023

Confirmation that no pipelines are currently in use:

⎈ aaw-prod-cc-00-aks~aaw$ kubectl get workflows -ALL
No resources found
⎈ aaw-prod-cc-00-aks~aaw$ kubectl get workflow -ALL
No resources found

@wg102
Copy link
Contributor Author

wg102 commented Jan 18, 2023

Where do we update the SHA of prod? What about the other changes?

@wg102
Copy link
Contributor Author

wg102 commented Jan 23, 2023

Test to ensure the rolebindings don't get created following https://github.com/StatCan/aaw-kubeflow-profiles-controller/pull/91/files in dev.

Sync up argocd prod so the uI changes are in. kubeflow-aaw-central-dashboard config map
Merge the aaw-kubflow-manifest pull 303 (may need a sync as well/

@wg102
Copy link
Contributor Author

wg102 commented Jan 23, 2023

Here is the plan on merging and testing it to Pipelines

At this point all the code will have been there.
And some of the resources are deleted when syncing

Some fast testing just to ensure that notebooks are functional can be done at this stage.

The following is cleanup and testing and should not affect availability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant