Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In appfs, find_protectable_free() must have skip_protection argument set to 0 #194

Open
tyler-gilbert opened this issue Mar 20, 2019 · 0 comments

Comments

@tyler-gilbert
Copy link
Member

Code snippet from appfs_util_root_create()

		//find space for the code -- this doesn't need to be protectable
		code_start_addr = find_protectable_free(dev, type, dest->exec.code_size, &page, 0);
		if ( code_start_addr == (u32)-1 ){
			return SYSFS_SET_RETURN(ENOSPC);
		}

The last arg of find_protectable_free() should be 1 (because files don't need to be a in protectable region) but doing that causes problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant