Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory view is kind of stinky #218

Open
NattyNarwhal opened this issue Oct 25, 2024 · 0 comments
Open

Directory view is kind of stinky #218

NattyNarwhal opened this issue Oct 25, 2024 · 0 comments
Labels
refactor Code cleanup

Comments

@NattyNarwhal
Copy link
Member

Stinky for lack of a better word. I'm rolling my own NSBrowser-like construct, but it has weird issues:

  • Double-click handler (onTapGesture) seems swallow normal single clicks a lot. It's weird.
    • The album view item works around this by installing its own NSGestureRecognizer, but this seems really awkward to do without an NSHostingView hoisting the whole thing.
  • Keyboard isn't handled for drill-down/deselect on left/right arrows; I think we can use focus bindings plus onKeyPress, but that latter API shows up in 14.

I'm tempted to just wrap NSBrowser or a modern replacement (i.e. this one) in NSViewRepresentable because I'd just be rolling my own version of miller columns in SwiftUI, but worse.

@NattyNarwhal NattyNarwhal added the refactor Code cleanup label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code cleanup
Projects
None yet
Development

No branches or pull requests

1 participant