Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookbook should support new defaultdateformats attribute. #151

Open
rickjuryxero opened this issue Apr 5, 2018 · 2 comments
Open

cookbook should support new defaultdateformats attribute. #151

rickjuryxero opened this issue Apr 5, 2018 · 2 comments

Comments

@rickjuryxero
Copy link
Contributor

Environment Information

Please include the following:

  • version of cookbook: 1.2.23
  • version of chef: any version
  • operating system: any
  • resources that are affected by issue:
    sumo_source_local_file in my use case, but it would affect any json source type.

Expected Behavior

as per: https://help.sumologic.com/Send-Data/Sources/03Use-JSON-to-Configure-Sources

defaultDateFormat is now deprecated. There is a newer defaultDateFormats object array that allows for specifying multiple timestamp formats and this is defaultDateFormats

It should be possible to create a source using the cookbook containing one or more date formats in defaultDateFormats

Actual Behavior

new attribute is missing from possible configuration options

Steps to Reproduce

defaultDateFormats doesn't exist as a possible attribute yet

Important Factoids

none

References

https://help.sumologic.com/Send-Data/Sources/03Use-JSON-to-Configure-Sources

@majormoses
Copy link
Collaborator

@rickjuryxero can you point me to what version it was deprecated? Hopefully we can write something to be backwards compatible by inspecting the version. If not we can do a major release where we can have breaking changes.

@rickjuryxero
Copy link
Contributor Author

I only found out about this after logging a case with sumo support about a source where we were having problems with auto timestamping (and previously you could only define a single manual timesstamp). The timestamping happens on the cloud side, so it doesn't seem to be tied to a particular agent version. I believe the change was fairly recent (like sometime 2018) but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants