Fetch mangas during the update #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make this an option/parameter of the endpoint? In Tachiomi this is a optional setting that is off by default. |
schroda
force-pushed
the
feature/updater_refresh_manga
branch
from
5c7598f to
02fb774
Compare
|
added a setting |
Syer10
approved these changes
Oct 29, 2023
|
Ill merge this after #738 is merged and there is a graphql setting for it. |
schroda
force-pushed
the
feature/updater_refresh_manga
branch
from
02fb774 to
80d37d9
Compare
The update only fetched the chapter list of a manga but never the manga itself. Thus, e.g. unless the manga got online fetched via the ui, it would never get recognized if it is completed or not. This would e.g. prevent the update setting, to not update completed mangas, from working as intended
schroda
force-pushed
the
feature/updater_refresh_manga
branch
from
80d37d9 to
ada2c1b
Compare
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update only fetched the chapter list of a manga but never the manga itself. Thus, e.g. unless the manga got online fetched via the ui, it would never get recognized if it is completed or not. This would e.g. prevent the update setting, to not update completed mangas, from working as intended