Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect behavior when in double page mode and chapter has spreads #795

Closed
drcorg opened this issue Sep 6, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@drcorg
Copy link

drcorg commented Sep 6, 2024

Device information

  • Suwayomi-WebUI version: r1816
  • Suwayomi-Server version: v1.1.1-r1566
  • Server Operating System: Windows 11
  • Server Desktop Environment: N/A
  • Server JVM version: bundled
  • Client Operating System: Windows 11
  • Client Web Browser: Google Chrome 128.0.6613.113

Steps to reproduce

  1. Open a manga chapter that contains a spread while in double page mode.

Expected behavior

While in double page mode, single pages preceding and succeeding spreads should be double paged unless unable to (i.e the spread is right after the first page, right before the last, or a single page is between two spreads).

Actual behavior

In chapter with spreads, the pages before or after the spread will be displayed as single paged instead of double paged.

Other details

This behavior seems to change based on whether the offset first page option is enabled. If the option is disabled, only the page before the spread will be a single, while if the option is enabled only the page after the spread will be a single. I've attached screenshots below.

Screenshots

With offset first page disabled:
image
image
image
With offset first page enabled:
image
image
image

@drcorg drcorg added the bug Something isn't working label Sep 6, 2024
@drcorg drcorg changed the title [Bug] Incorrect behavior when in double page mode and [Bug] Incorrect behavior when in double page mode and chapter has spreads Sep 6, 2024
@schroda
Copy link
Collaborator

schroda commented Sep 6, 2024

unless someone else will fix it, it will be fixed with #778 (was added to the list)

@schroda
Copy link
Collaborator

schroda commented Sep 30, 2024

should be fixed (83ce1ca)

@schroda schroda closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants