You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is because the build system assumes gsed exists without testing for it in configure, and your shell scripts using sed do not fail if the command errors.
Notice that the sed build system does not install a gsed executable on macOS. The gsed symlink is something specific to homebrew. So you should not assume gsed exists.
To Reproduce
% brew uninstall gsed
% <build lmod>
Expected behavior
Preferably just use portable sed commands.
Error out when a sed command fails during the build.
If you really can't use portable sed commands, then please:
Test whether sed works for your types of replacements in the configure script
Allow users to specify what sed command to use in configure. Basically I wanna avoid that if I specify a dependency on sed in my package manager, the lmod build will insist on gsed which doesn't exist on my macbook, cause my gnu sed executable is just called sed.
Desktop (please complete the following information):
OS: macOS
Lmod Version: 8.7.55
The text was updated successfully, but these errors were encountered:
I have switched to use the dump-down version of sed on macOS. Please test the IS742-gsed branch to see if it works for you. Thanks for reporting this issue.
Describe the bug
When building lmod on macOS, the build succeeds, but all init scripts are empty, so the installation is entirely broken:
This is because the build system assumes
gsed
exists without testing for it inconfigure
, and your shell scripts usingsed
do not fail if the command errors.Notice that the
sed
build system does not install agsed
executable on macOS. Thegsed
symlink is something specific to homebrew. So you should not assumegsed
exists.To Reproduce
Expected behavior
sed
commands.sed
command fails during the build.If you really can't use portable
sed
commands, then please:sed
works for your types of replacements in the configure scriptsed
in my package manager, the lmod build will insist ongsed
which doesn't exist on my macbook, cause my gnu sed executable is just calledsed
.Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: