From 639f1e89aeba0873547b301d98dd2ec07c43c841 Mon Sep 17 00:00:00 2001
From: Wesley Bomar <wbomar@tacc.utexas.edu>
Date: Wed, 12 Jun 2024 14:48:58 -0500
Subject: [PATCH 1/5] fix: tup-715 ugly urls for subdomain links

---
 .../snippets/js-prevent-ugly-urls.html        | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html

diff --git a/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
new file mode 100644
index 000000000..e1b78006e
--- /dev/null
+++ b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
@@ -0,0 +1,22 @@
+<script type="module" id="js-prevent-ugly-urls-tup-715">
+    const links = document.querySelectorAll('body > :is(header, main, footer) a[target="_blank"]');
+
+    [ ...links ].forEach( function tup715(link) {
+        const isTACC = document.location.host.includes('tacc.utexas.edu');
+
+        if ( isTACC ) {
+            let currentHrefVal = link.getAttribute('href');
+
+            link.setAttribute('data-original-href', currentHrefVal );
+            link.addEventListener('click', () => {
+                const originalHrefVal = link.getAttribute('data-original-href');
+
+                currentHrefVal = link.getAttribute('href');
+
+                if ( currentHrefVal !== originalHrefVal ) {
+                    link.setAttribute('href', originalHrefVal );
+                }
+            });
+        }
+    });
+</script>

From e510af6b8293c4534e47f5cbdc90ea71921366a7 Mon Sep 17 00:00:00 2001
From: Wesley B <62723358+wesleyboar@users.noreply.github.com>
Date: Wed, 12 Jun 2024 14:58:02 -0500
Subject: [PATCH 2/5] docs: tup-715 explain code

---
 .../taccsite_cms/templates/snippets/js-prevent-ugly-urls.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
index e1b78006e..318aa62dc 100644
--- a/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
+++ b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
@@ -1,7 +1,8 @@
 <script type="module" id="js-prevent-ugly-urls-tup-715">
     const links = document.querySelectorAll('body > :is(header, main, footer) a[target="_blank"]');
 
-    [ ...links ].forEach( function tup715(link) {
+    /* To revert URL of links that Google changes on hover */
+    [ ...links ].forEach( function restorLinkHrefIfChangedOnHover(link) {
         const isTACC = document.location.host.includes('tacc.utexas.edu');
 
         if ( isTACC ) {
@@ -12,7 +13,6 @@
                 const originalHrefVal = link.getAttribute('data-original-href');
 
                 currentHrefVal = link.getAttribute('href');
-
                 if ( currentHrefVal !== originalHrefVal ) {
                     link.setAttribute('href', originalHrefVal );
                 }

From 1c5b24cdb716bd9211272c4b2baceb4bb95038e3 Mon Sep 17 00:00:00 2001
From: Wesley B <62723358+wesleyboar@users.noreply.github.com>
Date: Wed, 12 Jun 2024 14:59:30 -0500
Subject: [PATCH 3/5] docs: tup-715 more details about code

---
 .../taccsite_cms/templates/snippets/js-prevent-ugly-urls.html  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
index 318aa62dc..78c628ddc 100644
--- a/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
+++ b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
@@ -1,7 +1,8 @@
 <script type="module" id="js-prevent-ugly-urls-tup-715">
     const links = document.querySelectorAll('body > :is(header, main, footer) a[target="_blank"]');
 
-    /* To revert URL of links that Google changes on hover */
+    /* HACK: To revert URL of links that Google changes on hover */
+    /* FAQ: Google Analytics settings interpret subdomain links as URLs to adjust so it can track navigation */
     [ ...links ].forEach( function restorLinkHrefIfChangedOnHover(link) {
         const isTACC = document.location.host.includes('tacc.utexas.edu');
 

From b02a46bb84e2caa5e383c0aa7b544d47794223d5 Mon Sep 17 00:00:00 2001
From: Wesley B <62723358+wesleyboar@users.noreply.github.com>
Date: Wed, 12 Jun 2024 15:00:46 -0500
Subject: [PATCH 4/5] style: tup-715 better function name

---
 .../taccsite_cms/templates/snippets/js-prevent-ugly-urls.html   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
index 78c628ddc..d7cb60f0e 100644
--- a/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
+++ b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
@@ -3,7 +3,7 @@
 
     /* HACK: To revert URL of links that Google changes on hover */
     /* FAQ: Google Analytics settings interpret subdomain links as URLs to adjust so it can track navigation */
-    [ ...links ].forEach( function restorLinkHrefIfChangedOnHover(link) {
+    [ ...links ].forEach( function restoreLinkHrefChangedOnHover(link) {
         const isTACC = document.location.host.includes('tacc.utexas.edu');
 
         if ( isTACC ) {

From 5848c45d7df78ca58cebaecd315d252cd7102116 Mon Sep 17 00:00:00 2001
From: Wesley Bomar <wbomar@tacc.utexas.edu>
Date: Mon, 1 Jul 2024 17:31:51 -0500
Subject: [PATCH 5/5] fix: TUP-715 check link not doc

Because doc is always tacc. Link is what may not be tacc.
---
 .../taccsite_cms/templates/snippets/js-prevent-ugly-urls.html   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
index d7cb60f0e..d7869244f 100644
--- a/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
+++ b/apps/tup-cms/src/taccsite_cms/templates/snippets/js-prevent-ugly-urls.html
@@ -4,7 +4,7 @@
     /* HACK: To revert URL of links that Google changes on hover */
     /* FAQ: Google Analytics settings interpret subdomain links as URLs to adjust so it can track navigation */
     [ ...links ].forEach( function restoreLinkHrefChangedOnHover(link) {
-        const isTACC = document.location.host.includes('tacc.utexas.edu');
+        const isTACC = link.host.includes('tacc.utexas.edu');
 
         if ( isTACC ) {
             let currentHrefVal = link.getAttribute('href');