Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding --allow-asynch argument to poll client script #159

Open
MarkDavidson opened this issue Dec 13, 2014 · 4 comments
Open

Consider adding --allow-asynch argument to poll client script #159

MarkDavidson opened this issue Dec 13, 2014 · 4 comments

Comments

@MarkDavidson
Copy link
Contributor

As I was re-writing the query script, I came across this line:
parser.add_argument("--allow-asynch", dest="allow_asynch", default=True, help="Indicate whether or not the client support Asynchronous Polling. Defaults to True")

Currently, none of the other scripts have it. Adding this argument should be considered.

-Mark

@gtback
Copy link
Contributor

gtback commented Dec 15, 2014

If we do this, can we use async rather than asynch? The former seems much more common than the latter.

@bworrell
Copy link
Contributor

@gtback, 👍

@MarkDavidson
Copy link
Contributor Author

Normally I'd be all for that, but I think I'm against it because the TAXII Specifications call it allow_asynch, and it's currently implemented as allow_asynch in libtaxii.messages_11 [1]

That said, there's an argument to be made that the CLI doesn't have to 100% mirror the code/specs.

Thoughts?
-Mark

[1] https://github.com/TAXIIProject/libtaxii/blob/master/libtaxii/messages_11.py#L2545 .

@gtback
Copy link
Contributor

gtback commented Dec 16, 2014

Since it's directly mapping to a component of the TAXII spec, I'll (begrudgingly) admit that it's probably better to leave it as asynch. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants