Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport TAXII 1.1 field names to messages_10 #206

Open
MarkDavidson opened this issue Dec 14, 2015 · 0 comments
Open

Backport TAXII 1.1 field names to messages_10 #206

MarkDavidson opened this issue Dec 14, 2015 · 0 comments

Comments

@MarkDavidson
Copy link
Contributor

Processing TAXII 1.0 and TAXII 1.1 Poll Requests currently requires separate code paths because some variables are close-but-not-quite, or are not present in TAXII 1.0 but could be reasonably defaulted to certain values.

This issue proposes the following changes to TAXII 1.0 Poll Requests

  • adding a collection_name field that is an alias to feed_name
  • adding a poll_parameters property from messages_11.PollParameters that uses the defaults plus content_bindings=poll_request.content_bindings

This can be monkey-patched in code that uses libtaxii by performing the following:

if poll_request.version == tc.VID_TAXII_XML_10:
    poll_request.collection_name = poll_request.feed_name
    poll_request.poll_parameters = messages_11.PollParameters(content_bindings=poll_request.content_bindings)

Then code can treat Poll Request 1.0 and Poll Request 1.1 objects the same way.

Thank you.
-Mark

(Updated 3x since original posting)

@gtback gtback removed their assignment Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants