Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Build instructions in CONTRIBUTING.md are imperfect #136

Closed
Nix-da opened this issue Jan 18, 2024 · 2 comments
Closed

[BUG]: Build instructions in CONTRIBUTING.md are imperfect #136

Nix-da opened this issue Jan 18, 2024 · 2 comments

Comments

@Nix-da
Copy link

Nix-da commented Jan 18, 2024

What is the bug?
Two commands in the building instructions are wrong:

Under the headline "Working in this repo" -> "steps to contribute" -> "5." is currently:
Run npm useChrome or npm useFF to select the browser you are developing for - this will copy the corresponding manifest.json

but has to be:
Run npm run useChrome or npm run useFF to select the browser you are developing for - this will copy the corresponding manifest.json

Also both scripts are not working on windows. This may also be worth a hint.

@C0ntroller
Copy link
Member

Fixed by #132
Will be merged into main with next release.

@OliEfr
Copy link
Member

OliEfr commented Jan 18, 2024

What is the bug? Two commands in the building instructions are wrong:

Under the headline "Working in this repo" -> "steps to contribute" -> "5." is currently: Run npm useChrome or npm useFF to select the browser you are developing for - this will copy the corresponding manifest.json

but has to be: Run npm run useChrome or npm run useFF to select the browser you are developing for - this will copy the corresponding manifest.json

Also both scripts are not working on windows. This may also be worth a hint.

Thanks @Nix-da For being attentive and reporting anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants