Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error initializing MultiViewAtlas from anndata object #13

Closed
nadavyayon opened this issue Dec 4, 2022 · 8 comments · Fixed by #11
Closed

Error initializing MultiViewAtlas from anndata object #13

nadavyayon opened this issue Dec 4, 2022 · 8 comments · Fixed by #11

Comments

@nadavyayon
Copy link

Capture1

Capture2

@nadavyayon
Copy link
Author

before you ask, I tried to find your example .h5ad to see if it's specific to me but couldn't

@emdann
Copy link
Member

emdann commented Dec 4, 2022

thanks Nadav, does it work if you set the view hierarchy to:

view_hierarchy = {
'full':{'T_lineage':None, 'non_T_lineage':None}
}

?

@emdann emdann changed the title something doesn't work, see snapshots, thanks! Error initializing MultiViewAtlas from anndata object Dec 4, 2022
@emdann
Copy link
Member

emdann commented Dec 4, 2022

I think it might be related to #6

@nadavyayon
Copy link
Author

view_hierarchy = {
'full':{'T_lineage':None, 'non_T_lineage':None}
}

This didn't help unfortunately.. I tried your anndata and that works fine so the env is OK.
The only diffrence I could find between the 2 objects is that before it crashes it does modify the adata_full.obsm['view_assign'] and adds the "full" column in the leftmost column opposed to your object where it's added at the rightmost.... perhaps means nothing but maybe you have an idea...

@emdann
Copy link
Member

emdann commented Dec 5, 2022

First fix: one error here comes from having different view names in view_hierarchy and assing_tab (T_lineage vs T_Lineage)

but I still get another error, so let me dig

@emdann
Copy link
Member

emdann commented Dec 5, 2022

Solved: the index error came from having one view name that is a subset of the other (where "T_lineage" in "non_T_lineage" == True) 🤯 I'm pushing a fix to get_parent_view function now. Thanks for catching this edge case!

@emdann emdann linked a pull request Dec 5, 2022 that will close this issue
@emdann emdann closed this as completed Dec 5, 2022
@nadavyayon
Copy link
Author

Sure!

@nadavyayon
Copy link
Author

I did this to install in an updatable form
git clone https://github.com/emdann/multi-view-atlas.git
cd multi-view-atlas
pip install -e .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants