Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mva.pl.multiview_embedding is looking for the wrong obsm - > 'X_umap' #17

Open
nadavyayon opened this issue Dec 6, 2022 · 3 comments
Open

Comments

@nadavyayon
Copy link

After passing the object through the SCVI wrapper -> mva.tl.train_scvi_multiview
the obsm embedding umap coordinates are named 'X_umap' plus the name of the view
so 'X_umap_full' etc

This messes up mva.pl.multiview_embedding() and requires to state basis= specifically to that name.

Thanks!

@nadavyayon
Copy link
Author

correction you only need to fix the top view 'full' and not state for every subview,
So basis ='X_umap_full is the only thing that's needed for all views

@emdann
Copy link
Member

emdann commented Dec 6, 2022

Thanks for the catch, I will push a fix that renames mvatlas.mdata['full'].obsm['X_umap'] to mvatlas.mdata['full'].obsm['X_umap_full'] at the end of the scvi wrapper functions.

@emdann
Copy link
Member

emdann commented Dec 6, 2022

I've added tests and fixes in e611476
Can you try again pulling latest changes from master? If you still get errors can you post the full code to reproduce your error? Even if I don't have the object it's fine, just to see what are the steps used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants