Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TagInput): enhance max rows for TagInput component#3025 #3293

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat(TagInput): enhance max rows for TagInput component#3025 #3293

wants to merge 5 commits into from
+1,349 −1

Conversation

Shabi-x
Copy link

@Shabi-x Shabi-x commented Dec 23, 2024 •
edited by uyarn
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

当数量较多的时候，提供maxrows属性，设置最大展示行数
首先接受maxRows属性，配合传入的size使用css变量动态计算input容器的max-height
同时我发现有excessTagsDisplayType属性，当他为break-inline时才应该触发这个特性

📝 更新日志

  • feat(TagInput): 新增maxRowsAPI，用于设置最大展示行数

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@Shabi-x
Copy link
Author

Shabi-x commented Dec 23, 2024

如果有需要改进之处，欢迎批评指正！

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

完成

@uyarn
Copy link
Collaborator

uyarn commented Dec 25, 2024 •
edited
Loading

还需要补充.md文件 这个是站点展示API使用的

@uyarn
Copy link
Collaborator

uyarn commented Dec 25, 2024

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

@Shabi-x
Copy link
Author

Shabi-x commented Dec 25, 2024

还需要补充.md文件 这个是站点展示API使用的

好的！我明天学着做一下😉

@Shabi-x
Copy link
Author

Shabi-x commented Dec 26, 2024

@uyarn 我需要一些帮助，我在子模块common里修改了.md文档以及.less文件，并在主仓库提交了，但是pr里file changed内似乎没有同步...

@liweijie0812
Copy link
Collaborator

@uyarn 我需要一些帮助，我在子模块common里修改了.md文档以及.less文件，并在主仓库提交了，但是pr里file changed内似乎没有同步...

https://github.com/Tencent/tdesign-common 子仓库先到这里提PR

@Shabi-x
Copy link
Author

Shabi-x commented Dec 26, 2024

@uyarn 我需要一些帮助，我在子模块common里修改了.md文档以及.less文件，并在主仓库提交了，但是pr里file changed内似乎没有同步...

https://github.com/Tencent/tdesign-common 子仓库先到这里提PR

谢谢，我查看一下，麻烦您了

@Shabi-x Shabi-x mentioned this pull request Jan 21, 2025
Merged
16 tasks
@liweijie0812
Copy link
Collaborator

/update-common

@liweijie0812
Copy link
Collaborator

运行 git submodule update --init --remote
然后提交子仓变更

@Shabi-x
Copy link
Author

Shabi-x commented Jan 21, 2025 •
edited
Loading

运行 git submodule update --init --remote 然后提交子仓变更

您好，打扰一下，是
image
之后把common仓库的内容修改同步到tdesign-react中嘛

@liweijie0812
Copy link
Collaborator

是的，把变更的src/_common 提交上来

@Shabi-x
Copy link
Author

Shabi-x commented Jan 21, 2025

运行 git submodule update --init --remote 然后提交子仓变更

好的，您看一下最新的提交是否可以了

Shabi-x
Shabi-x commented Jan 21, 2025
View reviewed changes
src/_common Outdated Show resolved Hide resolved
@HaixingOoO
Copy link
Collaborator

@liweijie0812 @uyarn 需要看一下為什麼_common會衝突

@liweijie0812
Copy link
Collaborator

要合一下develop分支

@uyarn
Copy link
Collaborator

uyarn commented Jan 23, 2025

/update-common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

@HaixingOoO HaixingOoO Awaiting requested review from HaixingOoO HaixingOoO is a code owner

@NWYLZW NWYLZW Awaiting requested review from NWYLZW NWYLZW is a code owner

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shabi-x @uyarn @liweijie0812 @HaixingOoO