From 78e474504d2c8e18cec8f78c8fc2731e127f51cd Mon Sep 17 00:00:00 2001 From: Nanda Date: Fri, 29 Nov 2024 11:27:56 +1100 Subject: [PATCH 1/2] Fix for copying binary files in gulp 5. Gulp5 requires passing `encoding: false` when copying binary files to prevent re-encoding as utf8. --- gulpfile.js | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index 853547c02..c9fc1fad9 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -164,7 +164,7 @@ gulp.task("copy-terriajs-assets", function () { var destPath = path.resolve(__dirname, "wwwroot", "build", "TerriaJS"); return gulp - .src([sourceGlob], { base: terriaWebRoot }) + .src([sourceGlob], { base: terriaWebRoot, encoding: false }) .pipe(gulp.dest(destPath)); }); diff --git a/package.json b/package.json index c3af7e9ae..be42eaa46 100644 --- a/package.json +++ b/package.json @@ -60,7 +60,7 @@ "fork-ts-checker-notifier-webpack-plugin": "^6.0.0", "fork-ts-checker-webpack-plugin": "^6.0.0", "fs-extra": "^7.0.1", - "gulp": "^4.0.0", + "gulp": "^5.0.0", "husky": "^8.0.3", "is-subdir": "^1.2.0", "json5": "^2.1.0", From 2f53b9f7cef35ae45874e52d7687c04ca6ed6a54 Mon Sep 17 00:00:00 2001 From: Nanda Date: Fri, 29 Nov 2024 12:52:35 +1100 Subject: [PATCH 2/2] Update CHANGES.md. --- CHANGES.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index 1a14db1bf..60f9f9dd5 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,10 @@ # Change Log +#### next release (0.2.3) + +- Upgraded gulp to version 5 + - Gulp 5 defaults to encoding copied files as utf-8, had turn off encoding by setting `encoding: false` to correctly copy binary assets from dependencies. + ### `0.2.2` **2024-11-22**