Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Previews Loading 5.5 Data #309

Open
MlleCanary opened this issue Dec 1, 2022 · 2 comments
Open

Page Previews Loading 5.5 Data #309

MlleCanary opened this issue Dec 1, 2022 · 2 comments
Labels
bug Something isn't working low prio Has low prio

Comments

@MlleCanary
Copy link
Collaborator

image
Image provided.

@MlleCanary MlleCanary added bug Something isn't working low prio Has low prio labels Dec 1, 2022
@nonowazu
Copy link
Contributor

nonowazu commented Dec 1, 2022

This is because the opengraph description is summarizing the body content:

king@xenogears:~$ wget -q -O - https://www.thebalanceffxiv.com/jobs/healers/scholar/best-in-slot/ | grep 'og:desc'
<meta property="og:description" content="SCH BiS and Gear Options 5.55 Savage Sets So, why the hell is SCH BiS 2.32 GCD this tier? The short answer is that our gear absolutely sucks for 2.41 this tier. We either have to take on a bunch of piety or use crafted gear, and neither one is efficient. 2.32 GCD lines up AF well, but sits on a sort of halfway point of DoT timings that requires us to alternate between 12 GCD and 13 GCD Bios, which can result in lost Bio ticks.">

If you look at the body of that page:

# SCH BiS and Gear Options

# 5.55 Savage Sets

***So, why the hell is SCH BiS 2.32 GCD this tier?***  \
The short answer is that our gear absolutely sucks for 2.41 this tier. We either have to take on a bunch of piety or use crafted gear, and neither one is efficient. 2.32 GCD lines up AF well, but sits on a sort of halfway point of DoT timings that requires us to alternate between 12 GCD and 13 GCD Bios, which can result in lost Bio ticks. This still makes it the most efficient GCD that we're able to hit at the moment damage wise, that doesn't throw off AF alignment or give us meme levels of mana efficiency.

Whereas the rendering for that template happens entirely out of the bis field in the front matter header. If you go to that link and click blame, you'll see that the content there was put in place 15 months ago — and the summary is drawing from that. The current editor config doesn't allow anyone to edit the body field, so that has remained untouched for the last ~15 months.

tl;dr - this isn't a bug in glam or the editor; remove the stuff in the body and it'll fix itself. For actual opengraph embeds, #308 has seo embeds which should fix that.

@nonowazu
Copy link
Contributor

I think this issue can be closed. I spot-checked a few best-in-slot.md files and didn't see a body anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low prio Has low prio
Projects
None yet
Development

No branches or pull requests

2 participants