Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle alternate artworks within the same set with the same collector number #15

Open
damprazis opened this issue Jan 15, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@damprazis
Copy link

Hello!

I am experiencing an issue while uploading the converted csv files to deckbox.org.
I can't really figure out if it is a conversion issue or the csv's issue in terms of with what name the cards were saved in the TCGPlayer app's export file.

I will put a link of the screenshot from the page's error while I am trying to upload a specific converted csv file.

https://ibb.co/tm8S50s

@ThePieBandit ThePieBandit self-assigned this Jan 16, 2022
@ThePieBandit ThePieBandit added the enhancement New feature or request label Jan 16, 2022
@ThePieBandit
Copy link
Owner

Hello, first of all, thank you for using my software!

I have some good news and bad news. The good news is that There is another branch feature/scryfallData which already has the "fix" for this. It has an issue compiling into an executable, but it works better if running from pure python.

The bad news is that the fix isn't perfect for this scenario, it just drops everything in the parenthesis. When it comes to these older sets that a) don't have official collector numbers and b) have alternate arts, the numbers and information don't line up. Take your Storm Crow. There's a flying left and a flying right version. TCG calls them both card #55, Deckbox calls one #55 and one #54. So it may add the wrong art version of the card into your collection.

The long term fix is to build a replacement list, finding these specific card names, and if they match, reduce the card number by 1. To do this, I would need to build a list of all cards with alternate arts in the same set.

In the short term, if these are the only cards that are giving you problems, you can download the CSV with invalid rows, which will only contain those, and you can edit them and just import them. The alternative is to use the other branch and run it with python directly, and then update the specific versions of these cards if you care about that.

I'm going to leave this issue open to implement the long term solution, but in the meantime, thank you again for using this tool and I hope the workarounds work for you in the meantime.

@ThePieBandit ThePieBandit changed the title Issue while uploading the converted csv files to deckbox.org Handle alternate artworks within the same set with the same collector number Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants