Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using ArduinoJSON as serial protocol #6

Open
tobiasdiez opened this issue Nov 5, 2020 · 3 comments
Open

Consider using ArduinoJSON as serial protocol #6

tobiasdiez opened this issue Nov 5, 2020 · 3 comments

Comments

@tobiasdiez
Copy link
Contributor

Currently you use a custom serial protocol to communicate between the Arduino and the host. It might be more robust/extendable to use JSON as the format. This should also streamline the code somewhat.

ArduinoJSON seems to be a great library for this. Of course, there is a bit of overhead involved when using JSON (see https://arduinojson.org/news/2019/11/19/arduinojson-vs-arduino_json/ for performance details).
@TheStaticTurtle
Copy link
Owner

True I might look into it but you just thrown a lot of changes at me in no time 😃 so I will need some time to do all that especially since I don't have a lot of it

@tobiasdiez
Copy link
Contributor Author

Sure, take your time. There is no need for hurry!

@TheStaticTurtle
Copy link
Owner

Opened a new branch for it (arduino_json_migration), might be a couple of weeks until I finish it really busy right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobiasdiez @TheStaticTurtle