Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Modal for Sub Confirm Page #37

Closed
wants to merge 1 commit into from
Closed

Add Modal for Sub Confirm Page #37

wants to merge 1 commit into from

Conversation

Dark1z
Copy link
Contributor

@Dark1z Dark1z commented Feb 3, 2021

Fix #2

Add Modal for Group Subscription Confirm Page

I have tested this on Group Subscription v1.2.0-beta,
I have done the required changes for Group Subscription v1.3.0-beta4,
hence kindly do a through check/test for Group Subscription v1.3.0-beta4.

You can do further changes as-per your wish,
like JavaScript changes for stevotvr_groupsub_set_term_id(...) function, ...etc...

Best regards 👍

Add Modal for Sub Confirm Page
dbfb72d 
Fix #2

Signed-off-by: Dark❶ <[email protected]>
@stevotvr
Copy link
Member

stevotvr commented Feb 7, 2021

What does this do? Can you post some screenshots?

@Dark1z
Copy link
Contributor Author

Dark1z commented Feb 8, 2021 •
edited
Loading

What does this do? Can you post some screenshots?

@stevotvr ,
Here for Group Subscription v1.2.0-beta :
1
which fix #2

Also, Kindly restart all the GitHub Actions CI Tests.

Best regards 👍

@stevotvr
Copy link
Member

stevotvr commented Feb 8, 2021

Thanks for the screenshot. Can you update it so that it doesn't use inline JavaScript?

@Dark1z
Copy link
Contributor Author

Dark1z commented Feb 8, 2021

Thanks for the screenshot. Can you update it so that it doesn't use inline JavaScript?

Ok, I'll try.

@Dark1z
Copy link
Contributor Author

Dark1z commented Feb 9, 2021 •
edited
Loading

@stevotvr ,

I tried with Group Subscription v1.3.0-beta4 ,
it's impossible to create Modal with above version.

It works with Group Subscription v1.2.0-beta,
since it does not need PayPal SDK js.

If Group Subscription v1.3.0-beta4 can be implemented without use of PayPal SDK js,
then I can make it possible,
but I do not know how to "implemented without use of PayPal SDK js",
that you will have to do for me.

If you don't want to "implemented without use of PayPal SDK js",
Then, Close this PR & #2 , after reading.

Best regards 👍

@Dark1z
Copy link
Contributor Author

Dark1z commented Apr 3, 2021

@FlashTVR || @StrontiumDogeh ,

Anybody active here ???
Also, Who is going to manage this project henceforth ???

Best regards 👍

@FlashTVR
Copy link
Member

FlashTVR commented Apr 3, 2021

@Dark1z Thanks for the ping, I didn't notice there were open PRs.

We're still settling into our "new normal" without Stevo. None of us are very familiar with this code yet, I'll try to review your commits soon.

@Dark1z
Copy link
Contributor Author

Dark1z commented Apr 3, 2021 •
edited
Loading

@Dark1z Thanks for the ping, I didn't notice there were open PRs.

We're still settling into our "new normal" without Stevo. None of us are very familiar with this code yet, I'll try to review your commits soon.

Kindly check this comment : #37 (comment)

then close this PR along with this Issue : #2
Since making a modal is no longer possible.

Best regards 👍

@Dark1z Dark1z closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal For SubScribe Page
3 participants
@Dark1z @stevotvr @FlashTVR