-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI using QT #39
Draft
TheoW03
wants to merge
158
commits into
master
Choose a base branch
from
QtUi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
GUI using QT #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated CMake file to hopefully work better with the overall project Upgraded cpp code to cpp20
Qt UI Prototype
Using ptrs finally clicked in my head, we goin' places
Classes are easier to read "romlist" -> "RomList" Updated sort/order functions to work better
You can now use the search bar RomList's compare functions now fallback to comparing title of RomData if the values are equal
If the current sort mode is sort by favorite, then update the display when a rom is favorited
Changed the rom count and display limit to 5000 for stress testing You can now scroll if the rom list widget is too large for the main window Added missing members to mainwindow.h
Roms are displayed in pages for performance, reaching the beginning or end of the scroll bar changes pages If there is no scroll bar, scrolling once up or down will also change pages
Prevent the user from accidentally changing pages
The bottom of the window displays which page you're on, and how much are displayed at a time
Some QStrings are replaced with tr() for possible future translation features Replaced string concat with format Renamed romlist FlowLayout widget Changed method of accessing romlist layout object page_info QLabel is now a child of the main window's QStatusBar object instead of main window
Moving headers to src/include Moving translation files to src/gui/translations
Added shader support, uses placeholder shader found online for now (details in crt_shader.frag)
Instead of there being a list of shared pointers, the list just stores raw pointers, this is for readability reasons The rom data's memory will now be cleaned up by RomList's deconstructor function (when the program shuts down) Updated a ton of getter function declarations to return a constant Removed u_short typedef in-favor of a more standard typedef (uint16_t) Replaced unsigned int declarations with uint32_t Fixed a possible bug where the var data's validation wasn't being checked correctly in RomListItem::RomListItem() Refactored some functions in RomList for better readablility RomList should update if rom dirs was changed in the settings Removed some assignments in header files and moved them into the class' constructor
Added a completer in the search bar on rom list Refactored how the game title is parsed in GameDisplay::GameDisplay()
[Bugfix] Game title no longer disappears after a second of displaying [Bugfix] Widgets in emulation settings have a more proper layout [Readability] Added a ton of comments in Settings_Display.cpp
[Refactor] Replaced include guards with "#pragma once" for all header files
note todo name tables in the future.
less reliant on constants more uniform vars
[Feature] Pause functionality finally works [Tweak] Moved 2 event connection declarations from EmulatorWorker to GameDisplay (Result should be the same) [Refactor] Removed QAction from GameDisplay as it did nothing, along with the slot function that connected to it [Refactor] Removed QMutex member as it is not needed anymore [Refactor] Removed mutex and m_paused params from EmulatorWorker constructor as it is not needed anymore [Refactor] Removed some instances of x += 1 and replaced them with x++
[Tweak] Remove unused include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still work in progress, and it may be Months before we merge this PR
but when we merge it will add a UI to the emulator. using QT.
as well as features such as palettes to the emulator and bug fixes.