-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on browser_style: true
#4
Comments
Yeah AFAIK/IIRC the dependency is not large, it is mostly the style of the controls and IIRC the style of the (reset) button was so flat that I never used it for that. Actually I also found rugk/offline-qr-code#44 and rugk/offline-qr-code#97 where you can actually see the default stuff I did not want to apply. |
In order to unblock migrations to MV3, I would just add the entire CSS file that Any optimization like removing everything unneeded can happen somewhen in the future. |
Copied from https://github.com/mozilla/gecko-dev/blob/338230dfeb14c047b55228a21b3e49657f00ae83/browser/components/extensions/extension.css This is the unmodified CSS file that gets included in Firefox in WebExtension Manifest V2 addons, when they choose to use `browser_style: true` `browser_style: true` is removed in Manifest V3, therefore addons need a replacement. One quick fix is to include this CSS file locally. See also TinyWebEx#4
Hmm a neat idea, though we did not use that much, IIRC. Dunno, what is your opinion, @tdulcet? |
Yeah, I would vote to just add at most the small subset of global styles from the style sheet, maybe without the Lines 22 to 40 in f0b844d
|
As of Firefox 118, support for
browser_style: true
was removed from Manifest V3. This library should include any CSS needed to follow the Firefox/Thunderbird Photon design locally. See the migration guide on MDN for more information. Also see this comment on BMO for more details on what specific styles were removed and their effect.This would be needed for TinyWebEx/common#14.
The text was updated successfully, but these errors were encountered: