Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow down Godot 4.3 as soon as I add the addon #593

Open
metal3d opened this issue Jan 15, 2025 · 4 comments
Open

Slow down Godot 4.3 as soon as I add the addon #593

metal3d opened this issue Jan 15, 2025 · 4 comments

Comments

@metal3d
Copy link

metal3d commented Jan 15, 2025

Terrain3D version

v0.9.3a-beta

System information

Godot 4.3 stable

Is the issue reproducable in the demo?

Yes

Issue description

Godot works perfectly.
Launching the Demo of Terrain3D as a game is OK, very fast and smooth

But, Godot interface is very slow after having activated the addon. Rotating the view, zooming, and so on is very slow.

Note that I've got an old CPU. I've got a Nvidia 3090 RTX but the cpu is "Intel(R) Core(TM) i7-3770 CPU @ 3.40GH" (8 cores). I know that this model doesn't accept AVX2 instructions.

I'm using Godot on Fedora 41

PS: I will try to recompile the module myself.

Logs

SCRIPT ERROR: Invalid call. Nonexistent function 'set_setting' in base 'previously freed'.
          at: save_editor_settings (res://addons/terrain_3d/src/asset_dock.gd:418)
SCRIPT ERROR: Invalid call. Nonexistent function 'set_setting' in base 'previously freed'.
          at: save_editor_settings (res://addons/terrain_3d/src/asset_dock.gd:418)
@metal3d
Copy link
Author

metal3d commented Jan 15, 2025

Recompiled the addon, it's now fast!

I wonder what happens with the release package. But it deserves some inspection. I will try on another (more recent) computer.

@TokisanGames
Copy link
Owner

We've had countless users on this version using Godot 4.3 who haven't experienced this error or slowdowns, so that warrants more exploration on your system.

The CPU is fine. We have users on much slower systems. We don't use AVX2.

Are you using the latest nvidia binary drivers? Which version?

Godot interface is very slow after having activated the addon. Rotating the view, zooming, and so on is very slow.

We don't control the interface. Did you experience this both while the Terrain3D node was selected and not selected? Did it also occur after closing all scenes? Our UI code only runs if Terrain3D is selected.

I wonder what happens with the release package

How exactly did you install it the first time if not using the release package?

Was it slow after restarting Godot twice during installation?

These errors shouldn't exist. What action did you perform that triggered this error?

SCRIPT ERROR: Invalid call. Nonexistent function 'set_setting' in base 'previously freed'.
          at: save_editor_settings (res://addons/terrain_3d/src/asset_dock.gd:418)

This function references a variable plugin which is a reference to the plugin itself. The only time it could be "previously freed" is maybe while enabling the plugin multiple times, or closing the engine.

What other plugins if any do you have installed in the demo project?

@metal3d
Copy link
Author

metal3d commented Jan 20, 2025

I remember that I accidentally removed the texture pane that is below the 3d view. And I never found how to get it anymore. The problem happened at this time.

I will try to reproduce.

(And yes, I've got latest Nvidia drivers, and the plugin works well. I will try to reopen the released demo. The problem is weird actually)

@TokisanGames
Copy link
Owner

I remember that I accidentally removed the texture pane that is below the 3d view. And I never found how to get it anymore.

If the plugin is working, you cannot remove the asset dock. You can however move it to any of the 8 sidebars, which might be what you did. It may be tabbed behind another panel like Scene/Import/Terrain3D. You may also have popped it out to a separate window and minimized it.

If you can reproduce it, we need exact steps and info to be able to address any bug found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants