Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_descr and info parameters not being exclusive for object descriptions #85

Open
Toma400 opened this issue Oct 7, 2023 · 3 comments
Open
Labels
code improvement Call for some improvement of code feature suggestion Feature suggestion, not approved by any means

Comments

@Toma400
Copy link
Owner

Toma400 commented Oct 7, 2023

At first, when doing classes, races and all other elements, info was default key which was required to aid IoA to description key.
However, I see that when doing attributes and skills at least, I started using .descr function which just added _descr to the regular key, making it much simpler, yet less controllable.
For now, for simplicity purposes, I will try to rewrite old stuff to work with .descr, however old idea of info key should still be available, if someone wants to override default naming.

@Toma400 Toma400 added feature suggestion Feature suggestion, not approved by any means code improvement Call for some improvement of code labels Oct 7, 2023
Toma400 added a commit that referenced this issue Oct 7, 2023
…move unnecessary `info`, alongside showcasing `descr` section to user
@Toma400
Copy link
Owner Author

Toma400 commented Oct 21, 2023

I think using Python function Lyofi suggested me for other thing could be handy, that were doing "get this key from dict, else N".

file.get("info", f"{file.get('key')}_descr")

Something along those lines. Since this issue is rather small, but neat, it will be passed to pre-alpha 3b.

@Toma400 Toma400 added this to the Pre-Alpha 3b milestone Oct 21, 2023
@Toma400 Toma400 mentioned this issue Oct 21, 2023
12 tasks
@Toma400
Copy link
Owner Author

Toma400 commented Oct 23, 2023

This requires more tweaking than I imagined at first, so I think I'm pushing this at least to pre-alpha 4. Don't want to bother myself with this kind of stuff when already boring things are in the way (translating).

#84 is basically biggest issue that keeps me from doing it with just simple few changes in code.

@Toma400 Toma400 modified the milestones: Pre-Alpha 3b, Pre-Alpha 4 Oct 23, 2023
@Toma400
Copy link
Owner Author

Toma400 commented Nov 11, 2023

Unbinding milestone for now, as part of code on which this issue bases on needs some proper rewrite overall.

@Toma400 Toma400 removed this from the Pre-Alpha 4 milestone Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement Call for some improvement of code feature suggestion Feature suggestion, not approved by any means
Projects
None yet
Development

No branches or pull requests

1 participant