Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing gui_types into separate modules #98

Open
Toma400 opened this issue Oct 24, 2023 · 0 comments
Open

Pushing gui_types into separate modules #98

Toma400 opened this issue Oct 24, 2023 · 0 comments
Labels
code improvement Call for some improvement of code

Comments

@Toma400
Copy link
Owner

Toma400 commented Oct 24, 2023

During pre-alpha 3 development, I quickly saw how enormous gui_types become because of putting all GUIs of the game in one place.
This was a thing I was thinking about for long to simplify, and eventually both my thinking and practice proved to be working - so I separated load.py from gui_types and made it working via such simple means.
Right now, other non-publicly-playable menus are built on this system, but the old ones are still in the same place.

Which is why this issue is made - all gui_types contents that are GUI building should be moved eventually to separate modules, so it is much cleaner to read GUI code.
With character creation or settings, where multiple layers of GUI are used, there should be decision whether to keep them together (bulkier variant) or separate each "second layer" type of GUI.

@Toma400 Toma400 added the code improvement Call for some improvement of code label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement Call for some improvement of code
Projects
None yet
Development

No branches or pull requests

1 participant