Issue: When defender surrendered, /swa siege end makes defender win

[DiamantesIces]

Suggestion: Add /swa siege end option to choose whether the attacker or defender wins. As of the latest update, even when the defender surrendered, /swa siege end command makes the defender win instead of lose.

[Goosius1]

Thank you!

I split off the command blacklist option to another ticket #339

[Goosius1]

As for the issue about using "swa siege end":

---

• That command is not supposed to be used after a surrender. Because after a surrender, the siege is considered already ended.
• Generally I recommend against supporting a post-siege reassignment of winner, because that is a complex change to the data, which could result in complex data integrity problems.
• Short/Medium term, I suggest we add a validator to completely prevent (with error message) people from using /swa siege end after a siege has already ended.
• When that is done, this ticket can be closed

---

• The immediate resolution to your problem is to not use /swa siege end after a surrender. Instead, if you want to change a siege at that point, I recommend you use /swa siege remove.

[Goosius1]

• I tested this locally
• Findings
  • After a town surrender was confirmed, I could not use /swa siege end because it gave me the error "that town has no active sieges", as expected.
  • Thus I must assume that the replication steps you described involve a "pending-surrender".
• Resolution
  • The /swa command can indeed override a pending surrender (but not a confirmed surrender).
  • The result of the command depends on the siege balance.
  • I wouldn't want this command to ignore the siege balance, because that could mess up the data.
  • Nor would I want the command to automatically adjust the siege balance, as that would be very unexpected for users.
  • In your exact scenario, you can change the outcome of a pending-surrender, to a simulated-timed-outcome (win or loss), but you must first ensure that the balance is what you want, and adjust it if needed ---> zero or over will cause and attacker win, less than zero will cause a defender win.

[Goosius1]

Ticket closed as resolved

[DiamantesIces]

Thank you so much!