Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a marketplace/royalties strategy #54

Open
ghoul-sol opened this issue Mar 10, 2022 · 3 comments
Open

Consider adding a marketplace/royalties strategy #54

ghoul-sol opened this issue Mar 10, 2022 · 3 comments
Labels
Feature Request New product feature requests

Comments

@ghoul-sol
Copy link
Contributor

https://github.com/ghoul-sol/treasure-marketplace/blob/06dba996a7b6e4db7a242d49f2b149fb6db9e5fa/contracts/TreasureMarketplace.sol#L293

Following the OCP and taking into account already known requirements, consider incapsulating the fee calculation in a different strategy contract.

@fulldecent
Copy link
Contributor

fulldecent commented Mar 10, 2022

Good idea. May be out-of-scope for this contract.

Or if there will be message passing from the marketplace to the royalty contract, then it could be in-scope. But probably still out-of-scope for current work round.

@ghost
Copy link

ghost commented Mar 10, 2022

This came out of a conversation with Gaarp. I've put it there in case.

@ghoul-sol ghoul-sol added the question Further information is requested label Mar 10, 2022
@treasure-t1dev
Copy link
Contributor

Don’t worry about this as a re-launch blocker. This would be a simple migration and doesn’t need to be at the expense of the community

@ghoul-sol ghoul-sol added wontfix This will not be worked on Feature Request New product feature requests and removed question Further information is requested wontfix This will not be worked on labels Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New product feature requests
Development

No branches or pull requests

3 participants