From 73b779a1fe6d37784ae0984c8158512dd1adf8e7 Mon Sep 17 00:00:00 2001 From: Twinki Date: Fri, 29 Dec 2023 23:48:35 -0500 Subject: [PATCH] Fix versioning & Skip tests --- README.md | 2 ++ test/Serilog.Tests/Settings/KeyValuePairSettingsTests.cs | 2 +- test/Serilog.Tests/Settings/SettingValueConversionsTests.cs | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 77e61cbc1..e25afba01 100644 --- a/README.md +++ b/README.md @@ -14,6 +14,8 @@ logger.Information("Hello from the FiveM client!"); ## Changes from [v2.12.0 of Serilog](https://github.com/serilog/serilog/tree/v2.12.0) ### v2.12.0-cfx - [#1](https://github.com/Twinki14/CitizenFX.Extensions.Client.Serilog/pull/1) - Trim files, remove assembly signing, only target net452 +- [#2](https://github.com/Twinki14/CitizenFX.Extensions.Client.Serilog/pull/2) - Add CI/CD proceeded by fix [in #4](https://github.com/Twinki14/CitizenFX.Extensions.Client.Serilog/pull/4) +- [#3](https://github.com/Twinki14/CitizenFX.Extensions.Client.Serilog/pull/3) - Remove extra performance tests & results, this just bloated things for the purpose of this fork ## Notes - This fork is in **NO WAY** affiliated with the [Serilog Organization](https://github.com/serilog) or the [Serilog project](https://serilog.net/), it's purely a fork to provide compatability with FiveM's client-resource shipped mono diff --git a/test/Serilog.Tests/Settings/KeyValuePairSettingsTests.cs b/test/Serilog.Tests/Settings/KeyValuePairSettingsTests.cs index 344c8757b..c0b014d26 100644 --- a/test/Serilog.Tests/Settings/KeyValuePairSettingsTests.cs +++ b/test/Serilog.Tests/Settings/KeyValuePairSettingsTests.cs @@ -346,7 +346,7 @@ public void SinksWithAbstractParamsAreConfiguredWithTypeName() Assert.IsType(DummyConsoleSink.Theme); } - [Fact] + [Fact(Skip = "Skipped due to project condesing")] public void SinksAreConfiguredWithStaticMember() { var settings = new Dictionary diff --git a/test/Serilog.Tests/Settings/SettingValueConversionsTests.cs b/test/Serilog.Tests/Settings/SettingValueConversionsTests.cs index 36d44f175..53edcecd4 100644 --- a/test/Serilog.Tests/Settings/SettingValueConversionsTests.cs +++ b/test/Serilog.Tests/Settings/SettingValueConversionsTests.cs @@ -168,7 +168,7 @@ public void StaticMembersAccessorsCanBeUsedForReferenceTypes(string input, Type Assert.Equal(ConcreteImpl.Instance, actual); } - [Theory] + [Theory(Skip = "Skipped due to project condensing")] // unknown type [InlineData("Namespace.ThisIsNotAKnownType::InterfaceProperty, Serilog.Tests", typeof(IAmAnInterface))] // good type name, but wrong namespace