Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a square option to the settings object #1

Open
TyMick opened this issue Aug 10, 2020 · 0 comments
Open

Add a square option to the settings object #1

TyMick opened this issue Aug 10, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@TyMick
Copy link
Owner

TyMick commented Aug 10, 2020

Add a square option to the settings object to customize whether the hook treats windows of equal width and height as portrait, landscape, or neither. The hook currently treats them as portrait.

  • Options: "portrait", "landscape", "square"
  • Default: "portrait"

When set to "square", the hook should return { orientation: "square", portrait: false, landscape: false } when the window is square.

@TyMick TyMick added this to the 1.1 milestone Aug 10, 2020
@TyMick TyMick self-assigned this Aug 10, 2020
@TyMick TyMick added the enhancement New feature or request label Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant