-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing react types for 4 of the components #643
Comments
Features: * Export new types for react components (PopoverProps, PopupButtonProps, SidetabProp, SliderButtonProps, WidgetProps) - closes #643 Bug fixes: * Make children prop optional in the PopupButton and SliderButton
🎉 This issue has been resolved in version @typeform/embed-v4.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [@typeform/embed-react-v3.17.0](https://github.com/Typeform/embed/compare/@typeform/embed-react-v3.16.0...@typeform/embed-react-v3.17.0) (2024-04-16) ### Features * Bump @typeform/embed in @typeform/embed-react package [skip ci] ([29b1dc5](29b1dc5)) * **TU-9582:** Export correct prop types for react components ([#646](#646)) ([02030ab](02030ab)), closes [#643](#643)
🎉 This issue has been resolved in version @typeform/embed-react-v3.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi, @Multiply.
Thanks. |
I'll try out the latest version. Edit: Thanks, the implementation I posted now work correctly, as it can extract the component props directly. |
When importing all five components, and creating a simple wrapper around them for easily rendering in one place, we're mostly seeing it accept any type, which is not neat.
Sample code:
Please refer to my recording here for an example:
Screen.Recording.2024-03-06.at.05.32.10.mov
Edit:
I noticed the components are importing types from different folders, where
@typeform/embed
imports work, and@typeform/embed/types/base
doesn't.The text was updated successfully, but these errors were encountered: