From eca72f6b529b1e6a874b98979ffd02c11152ae5a Mon Sep 17 00:00:00 2001 From: Adam Blake Date: Wed, 20 Oct 2021 09:24:35 -0700 Subject: [PATCH 1/4] Bump version --- DESCRIPTION | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 90823d7..ee6d8ee 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Package: supernova Type: Package Title: Judd, McClelland, & Ryan Formatting for ANOVA Output -Version: 2.4.3 -Date: 2021-10-19 +Version: 2.4.4 +Date: 2021-10-20 Authors@R: c( person( "Adam", "Blake", From 2fe22513207206f8c95d9058eafabb01e50c78e5 Mon Sep 17 00:00:00 2001 From: Adam Blake Date: Wed, 20 Oct 2021 09:24:58 -0700 Subject: [PATCH 2/4] Remove supernova-vctrs from exports --- NAMESPACE | 1 - R/number.R | 8 +------- man/supernova-vctrs.Rd | 13 ------------- 3 files changed, 1 insertion(+), 21 deletions(-) delete mode 100644 man/supernova-vctrs.Rd diff --git a/NAMESPACE b/NAMESPACE index eef6132..622b9ba 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -63,7 +63,6 @@ export(ssr) export(superanova) export(supernova) export(variables) -export(vec_arith.supernova_number) import(vctrs) importFrom(ggplot2,"%+%") importFrom(ggplot2,autoplot) diff --git a/R/number.R b/R/number.R index 4976450..5d7ff05 100644 --- a/R/number.R +++ b/R/number.R @@ -1,8 +1,4 @@ -#' Internal `vctrs` methods -#' #' @import vctrs -#' @keywords internal -#' @name supernova-vctrs NULL @@ -152,10 +148,8 @@ vec_cast.supernova_number.character <- function(x, to, ...) { # Math ---------------------------------------------------------------------------------------- -#' @export #' @method vec_arith supernova_number -#' @export vec_arith.supernova_number -#' @rdname supernova-vctrs +#' @export vec_arith.supernova_number <- function(op, x, y, ...) { UseMethod("vec_arith.supernova_number", y) } diff --git a/man/supernova-vctrs.Rd b/man/supernova-vctrs.Rd deleted file mode 100644 index 82c0960..0000000 --- a/man/supernova-vctrs.Rd +++ /dev/null @@ -1,13 +0,0 @@ -% Generated by roxygen2: do not edit by hand -% Please edit documentation in R/number.R -\name{supernova-vctrs} -\alias{supernova-vctrs} -\alias{vec_arith.supernova_number} -\title{Internal \code{vctrs} methods} -\usage{ -\method{vec_arith}{supernova_number}(op, x, y, ...) -} -\description{ -Internal \code{vctrs} methods -} -\keyword{internal} From dbbce9f003c2a1de2dabc4bf312d2a72a43dda07 Mon Sep 17 00:00:00 2001 From: Adam Blake Date: Wed, 20 Oct 2021 09:25:32 -0700 Subject: [PATCH 3/4] Update changelogs --- NEWS.md | 4 ++++ cran-comments.md | 14 ++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/NEWS.md b/NEWS.md index 1fbb7ec..6c8a31e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +# supernova 2.4.4 + +* Remove `supernova-vctrs` from exports + # supernova 2.4.3 * Fix issues with `lintr` causing `R CMD CHECK` to fail diff --git a/cran-comments.md b/cran-comments.md index 99ed674..7f9d2b7 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,3 +1,17 @@ +*Previous reviewer asked for note explaining why package was removed:* +Package was removed from CRAN because it was fixed too late (by a couple of hours) on Oct. 19. The +problem was a recent bug in `lintr` that caused it to fail when running R CMD CHECK during the CRAN +build process. I implemented a workaround that is documented in the commit fixing the issue, if you +are interested. + +*Previous reviewer asked for additional documentation to `supernova-vctrs`*: +This was not a usable function/class and is just a collection of methods making the package +compatible with the `vctrs` package. I have removed `supernova-vctrs` from the exports. + +--- + +# Original comments on release: + ## Release summary * Fix issues with lintr causing R CMD CHECK to fail From ae14115e9285858c739cf1e338d98dee86d40e1b Mon Sep 17 00:00:00 2001 From: Adam Blake Date: Wed, 20 Oct 2021 09:28:09 -0700 Subject: [PATCH 4/4] Add codecov to dictionary --- inst/WORDLIST | 1 + 1 file changed, 1 insertion(+) diff --git a/inst/WORDLIST b/inst/WORDLIST index 0e0e36b..c009034 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -1,5 +1,6 @@ Bonferroni Codecov +codecov HSD McClelland PRE