From 59554667bce14a9434d94e4aec2178b2490f707e Mon Sep 17 00:00:00 2001 From: Adam Blake Date: Tue, 6 Feb 2024 17:27:56 -0800 Subject: [PATCH] chore: update cran comments --- cran-comments.md | 49 ++++++++++++++++++++++++++++++++++++++---------- revdep/README.md | 41 ++++++++++++++++++++-------------------- 2 files changed, 59 insertions(+), 31 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 6665fd0..78d0b3a 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,23 +1,53 @@ ## Release summary -- Don't trim the leading digit from p-value or PRE when they are exactly 1 -- Fix issue on CRAN check when lme4 (optional) is not installed but is used in tests +- Remove deprecated `superanova()` +- Remove `magrittr`, `ggplot2`, and `backports` dependencies ## Test environments -- Local install on macOS Monterey 13.1 (ARM); R 4.2.1 +- Local install on macOS Monterey 13.1 (ARM); R 4.3.2 - GitHub Actions - - macOS: 12.6.3; R: 4.2.3 - - Microsoft Windows Server 2022: 10.0.20348; R: 4.2.3, 3.6.3 - - Ubuntu: 18.04.6; R: devel, 4.2.3, 4.1.3 + - macOS: 12.7.2; R: 4.3.2 + - Microsoft Windows Server 2022: 10.0.20348; R: 4.3.2, 3.6.3 + - Ubuntu: 22.04.3; R: devel, 4.3.2, 4.2.3 - `check_rhub()` - `check_win_devel()` ## R CMD check results -0 errors v | 0 warnings v | 0 notes v +There were 4 notes during the CRAN checks. -R CMD check succeeded +1. I am the maintainer of the package and have updated the email address. + +``` +* checking CRAN incoming feasibility ... [15s] NOTE +Maintainer: 'Adam Blake ' + +New maintainer: + Adam Blake +Old maintainer(s): + Adam Blake +``` + +2. On Windows Server 2022, R-devel, 64 bit: + +``` +* checking for non-standard things in the check directory ... NOTE +Found the following files/directories: + ''NULL'' +``` + +As noted in [R-hub issue #560](https://github.com/r-hub/rhub/issues/560), this seems to be an Rhub issue and so can likely be ignored. + +3. On Windows Server 2022, R-devel, 64 bit: + +``` +* checking for detritus in the temp directory ... NOTE +Found the following files/directories: + 'lastMiKTeXException' +``` + +As noted in [R-hub issue #503](https://github.com/r-hub/rhub/issues/503), this could be due to a bug/crash in MiKTeX and can likely be ignored. ## Reverse dependencies @@ -25,5 +55,4 @@ Dependencies were identified with `devtools::revdep()` and tested with `revdepch Packages: -- coursekata -- eda4treeR +- eda4treeR (meta-package with no code) diff --git a/revdep/README.md b/revdep/README.md index 4d3628b..88efb6b 100644 --- a/revdep/README.md +++ b/revdep/README.md @@ -1,32 +1,31 @@ # Platform -|field |value | -|:--------|:--------------------------------| -|version |R version 4.3.1 (2023-06-16) | -|os |macOS Sonoma 14.0 | -|system |aarch64, darwin23.0.0 | -|ui |unknown | -|language |(EN) | -|collate |en_US.UTF-8 | -|ctype |en_US.UTF-8 | -|tz |America/Los_Angeles | -|date |2023-11-04 | -|pandoc |3.1.9 @ /opt/homebrew/bin/pandoc | +| field | value | +| :------- | :---------------------------------- | +| version | R version 4.3.2 (2023-10-31) | +| os | macOS Sonoma 14.2.1 | +| system | aarch64, darwin23.2.0 | +| ui | unknown | +| language | (EN) | +| collate | en_US.UTF-8 | +| ctype | en_US.UTF-8 | +| tz | America/Los_Angeles | +| date | 2024-02-06 | +| pandoc | 3.1.11.1 @ /opt/homebrew/bin/pandoc | # Dependencies -|package |old |new |Δ | -|:---------|:-----|:-----|:--| -|supernova |2.5.7 |2.5.8 |* | -|rlang |NA |1.1.2 |* | -|withr |NA |2.5.2 |* | +| package | old | new | Δ | +| :-------- | :---- | :---- | :-- | +| supernova | 2.5.8 | 3.0.0 | \* | # Revdeps ## Failed to check (2) -|package |version |error |warning |note | -|:----------|:-------|:-----|:-------|:----| -|coursekata |? | | | | -|eda4treeR |? | | | | +Though these fail to check, the failures are not related to `supernova`. The `coursekata` package has been removed from CRAN, and the `eda4treeR` package is a meta-package that does not have any code to check. +| package | version | error | warning | note | +| :--------- | :------ | :---- | :------ | :--- | +| coursekata | ? | | | | +| eda4treeR | ? | | | |